aclindsa
/
ofxgo
mirror of https://github.com/aclindsa/ofxgo.git
1
0
Fork 0
Code Issues Releases Wiki Activity

`go vet` and `golint`

This commit is contained in:
Aaron Lindsay 2017-04-18 19:50:04 -04:00
parent 1ee7197340
commit a3e42fc903
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common.go
View File

@ -274,6 +274,7 @@ type BankAcct struct {
AcctKey String `xml:"ACCTKEY,omitempty"` // Unused in USA
}
// Valid returns whether the BankAcct is valid according to the OFX spec
func (b BankAcct) Valid() (bool, error) {
if len(b.BankID) == 0 {
return false, errors.New("BankAcct.BankID empty")
@ -294,6 +295,7 @@ type CCAcct struct {
AcctKey String `xml:"ACCTKEY,omitempty"` // Unused in USA
}
// Valid returns whether the CCAcct is valid according to the OFX spec
func (c CCAcct) Valid() (bool, error) {
if len(c.AcctID) == 0 {
return false, errors.New("CCAcct.AcctID empty")

4
types.go
View File

@ -351,7 +351,7 @@ func (c *CurrSymbol) UnmarshalXML(d *xml.Decoder, start xml.StartElement) error
unit, err := currency.ParseISO(value)
if err != nil {
errors.New("Error parsing CurrSymbol:" + err.Error())
return errors.New("Error parsing CurrSymbol:" + err.Error())
}
c.Unit = unit
return nil
@ -375,6 +375,8 @@ func (c CurrSymbol) Valid() (bool, error) {
return true, nil
}
// NewCurrSymbol returns a new CurrSymbol given a three-letter ISO-4217
// currency symbol as a string
func NewCurrSymbol(s string) (*CurrSymbol, error) {
unit, err := currency.ParseISO(s)
if err != nil {