From ae525b742c3f7b053cca03f7f40c0eb4e61f6f28 Mon Sep 17 00:00:00 2001
From: Aaron Lindsay <aaron@aclindsay.com>
Date: Sat, 8 Apr 2017 08:58:09 -0400
Subject: [PATCH] Add test for signon validity

---
 signon_test.go | 122 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 122 insertions(+)
 create mode 100644 signon_test.go

diff --git a/signon_test.go b/signon_test.go
new file mode 100644
index 0000000..38224db
--- /dev/null
+++ b/signon_test.go
@@ -0,0 +1,122 @@
+package ofxgo_test
+
+import (
+	"github.com/aclindsa/ofxgo"
+	"testing"
+)
+
+func TestMarshalInvalidSignons(t *testing.T) {
+	var client = ofxgo.Client{
+		AppId:       "OFXGO",
+		AppVer:      "0001",
+		SpecVersion: "203",
+	}
+
+	var request ofxgo.Request
+	request.Signon.UserId = "myusername"
+	request.Signon.UserPass = "Pa$$word"
+	request.Signon.Org = "BNK"
+	request.Signon.Fid = "1987"
+
+	request.SetClientFields(&client)
+	_, err := request.Marshal()
+	if err != nil {
+		t.Fatalf("Unexpected error marshalling signon: %s\n", err)
+	}
+
+	request.Signon.UserKey = "mykey"
+	_, err = request.Marshal()
+	if err == nil {
+		t.Fatalf("Expected error due to key and password both being specified\n")
+	}
+
+	request.Signon.UserPass = ""
+	_, err = request.Marshal()
+	if err != nil {
+		t.Fatalf("Unexpected error marshalling signon: %s\n", err)
+	}
+
+	request.Signon.UserId = ""
+	_, err = request.Marshal()
+	if err == nil {
+		t.Fatalf("Expected error due to unspecified UserId\n")
+	}
+	request.Signon.UserId = "lakhgdlsakhgdlkahdglkhsadlkghaslkdghsalkdghalsdhg"
+	if err == nil {
+		t.Fatalf("Expected error due to UserId too long\n")
+	}
+	request.Signon.UserId = "myusername"
+
+	request.Signon.UserKey = "adlfahdslkgahdweoihadf98agrha87rghasdf9hawhra2hrkwahhaguhwaoefajkei23hff"
+	_, err = request.Marshal()
+	if err == nil {
+		t.Fatalf("Expected error due to UserKey too long\n")
+	}
+	request.Signon.UserKey = ""
+
+	request.Signon.UserPass = "adlfahdslkgahdweoihadf98agrha87rghasdf9hawhra2hrkwahhaguhwaoefajkei23hff"
+	_, err = request.Marshal()
+	if err == nil {
+		t.Fatalf("Expected error due to UserPass too long\n")
+	}
+	request.Signon.UserPass = "lakhgdlkahd"
+
+	request.Signon.Language = "English"
+	_, err = request.Marshal()
+	if err == nil {
+		t.Fatalf("Expected error due to Language too long\n")
+	}
+	request.Signon.Language = "EN"
+	_, err = request.Marshal()
+	if err == nil {
+		t.Fatalf("Expected error due to Language too short\n")
+	}
+	request.Signon.Language = ""
+	_, err = request.Marshal()
+	if err != nil || request.Signon.Language != "ENG" {
+		t.Fatalf("Empty Language expected to default to ENG: %s\n", err)
+	}
+	request.Signon.Language = "ENG"
+
+	request.Signon.AppId = ""
+	_, err = request.Marshal()
+	if err == nil {
+		t.Fatalf("Expected error due to missing AppId\n")
+	}
+	request.SetClientFields(&client)
+	_, err = request.Marshal()
+	if err != nil {
+		t.Fatalf("Client expected to set empty AppId: %s\n", err)
+	}
+	client.AppId = "ALKHGDH"
+	request.SetClientFields(&client)
+	_, err = request.Marshal()
+	if err == nil {
+		t.Fatalf("Expected error due to AppId too long\n")
+	}
+	client.AppId = "OFXGO"
+
+	request.Signon.AppVer = ""
+	_, err = request.Marshal()
+	if err == nil {
+		t.Fatalf("Expected error due to missing AppVer\n")
+	}
+	request.SetClientFields(&client)
+	_, err = request.Marshal()
+	if err != nil {
+		t.Fatalf("Client expected to set empty AppVer: %s\n", err)
+	}
+	client.AppVer = "00002"
+	request.SetClientFields(&client)
+	_, err = request.Marshal()
+	if err == nil {
+		t.Fatalf("Expected error due to AppVer too long\n")
+	}
+	client.AppVer = "0001"
+
+	request.SetClientFields(&client)
+	_, err = request.Marshal()
+	if err != nil {
+		t.Fatalf("Unexpected error after resetting all fields to reasonable values: %s\n", err)
+	}
+}