aclindsa/moneygo
1
0
Fork 0
mirror of https://github.com/aclindsa/moneygo.git synced 2024-12-26 15:42:27 -05:00
Code Issues Releases Wiki Activity

testing: Ensure account balance is correct after OFX import

Browse Source
This commit is contained in:
Aaron Lindsay 2017-11-26 21:01:26 -05:00
parent aa8924243e
commit d656f15e84
3 changed files with 20 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
internal/handlers/common_test.go
View File

@ -202,6 +202,18 @@ func uploadFile(client *http.Client, filename, urlsuffix string) error {
return nil return nil
} }
func accountBalanceHelper(t *testing.T, client *http.Client, account *handlers.Account, balance string) {
t.Helper()
transactions, err := getAccountTransactions(client, account.AccountId, 0, 0, "")
if err != nil {
t.Fatalf("Couldn't fetch account transactions for '%s': %s\n", account.Name, err)
}
if transactions.EndingBalance != balance {
t.Errorf("Expected ending balance for '%s' to be '%s', but found %s\n", account.Name, balance, transactions.EndingBalance)
}
}
func RunWith(t *testing.T, d *TestData, fn TestDataFunc) { func RunWith(t *testing.T, d *TestData, fn TestDataFunc) {
testdata, err := d.Initialize() testdata, err := d.Initialize()
if err != nil { if err != nil {

22
internal/handlers/gnucash_test.go
View File

@ -10,18 +10,6 @@ func importGnucash(client *http.Client, filename string) error {
return uploadFile(client, filename, "/v1/imports/gnucash") return uploadFile(client, filename, "/v1/imports/gnucash")
} }
func gnucashAccountBalanceHelper(t *testing.T, client *http.Client, account *handlers.Account, balance string) {
t.Helper()
transactions, err := getAccountTransactions(client, account.AccountId, 0, 0, "")
if err != nil {
t.Fatalf("Couldn't fetch account transactions for '%s': %s\n", account.Name, err)
}
if transactions.EndingBalance != balance {
t.Errorf("Expected ending balance for '%s' to be '%s', but found %s\n", account.Name, balance, transactions.EndingBalance)
}
}
func TestImportGnucash(t *testing.T) { func TestImportGnucash(t *testing.T) {
RunWith(t, &data[0], func(t *testing.T, d *TestData) { RunWith(t, &data[0], func(t *testing.T, d *TestData) {
// Ensure there's only one USD currency // Ensure there's only one USD currency
@ -100,11 +88,11 @@ func TestImportGnucash(t *testing.T) {
t.Fatalf("Couldn't find 'Expenses/Cable' account") t.Fatalf("Couldn't find 'Expenses/Cable' account")
} }
gnucashAccountBalanceHelper(t, d.clients[0], salary, "-998.34") accountBalanceHelper(t, d.clients[0], salary, "-998.34")
gnucashAccountBalanceHelper(t, d.clients[0], creditcard, "-272.03") accountBalanceHelper(t, d.clients[0], creditcard, "-272.03")
gnucashAccountBalanceHelper(t, d.clients[0], openingbalances, "-21014.33") accountBalanceHelper(t, d.clients[0], openingbalances, "-21014.33")
gnucashAccountBalanceHelper(t, d.clients[0], groceries, "287.56") // 87.19 from preexisting transactions and 200.37 from Gnucash accountBalanceHelper(t, d.clients[0], groceries, "287.56") // 87.19 from preexisting transactions and 200.37 from Gnucash
gnucashAccountBalanceHelper(t, d.clients[0], cable, "89.98") accountBalanceHelper(t, d.clients[0], cable, "89.98")
var ge *handlers.Security var ge *handlers.Security
securities, err := getSecurities(d.clients[0]) securities, err := getSecurities(d.clients[0])

3
internal/handlers/ofx_test.go
View File

@ -29,8 +29,11 @@ func TestImportOFX(t *testing.T) {
if err = importOFX(d.clients[0], d.accounts[1].AccountId, "handlers_testdata/checking_20171126.ofx"); err != nil { if err = importOFX(d.clients[0], d.accounts[1].AccountId, "handlers_testdata/checking_20171126.ofx"); err != nil {
t.Fatalf("Error importing OFX: %s\n", err) t.Fatalf("Error importing OFX: %s\n", err)
} }
accountBalanceHelper(t, d.clients[0], &d.accounts[1], "2493.19")
if err = importOFX(d.clients[0], d.accounts[1].AccountId, "handlers_testdata/checking_20171129.ofx"); err != nil { if err = importOFX(d.clients[0], d.accounts[1].AccountId, "handlers_testdata/checking_20171129.ofx"); err != nil {
t.Fatalf("Error importing OFX: %s\n", err) t.Fatalf("Error importing OFX: %s\n", err)
} }
accountBalanceHelper(t, d.clients[0], &d.accounts[1], "5336.27")
}) })
} }