From bcbb003e4026d777aded3b7a576c21f3074449aa Mon Sep 17 00:00:00 2001 From: Aaron Lindsay Date: Tue, 24 Oct 2017 20:13:42 -0400 Subject: [PATCH] users: Simplify deletion of prices and splits owned by a user The previous way was overly complex and didn't work with MySQL anyway --- internal/handlers/users.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/handlers/users.go b/internal/handlers/users.go index 63f3ccb..b73e5e8 100644 --- a/internal/handlers/users.go +++ b/internal/handlers/users.go @@ -143,11 +143,11 @@ func DeleteUser(tx *Tx, u *User) error { if count != 1 { return fmt.Errorf("No user to delete") } - _, err = tx.Exec("DELETE FROM prices WHERE prices.PriceId IN (SELECT prices.PriceId FROM prices INNER JOIN securities ON prices.SecurityId=securities.SecurityId WHERE securities.UserId=?)", u.UserId) + _, err = tx.Exec("DELETE FROM prices WHERE prices.SecurityId IN (SELECT securities.SecurityId FROM securities WHERE securities.UserId=?)", u.UserId) if err != nil { return err } - _, err = tx.Exec("DELETE FROM splits WHERE splits.SplitId IN (SELECT splits.SplitId FROM splits INNER JOIN transactions ON splits.TransactionId=transactions.TransactionId WHERE transactions.UserId=?)", u.UserId) + _, err = tx.Exec("DELETE FROM splits WHERE splits.TransactionId IN (SELECT transactions.TransactionId FROM transactions WHERE transactions.UserId=?)", u.UserId) if err != nil { return err }