From 871aa88ea6880f1ebf36886572646f1174a3c126 Mon Sep 17 00:00:00 2001
From: Aaron Lindsay <aaron@aclindsay.com>
Date: Sun, 8 Jan 2017 21:04:01 -0500
Subject: [PATCH] Convert NewUserPanel to a Modal, and to use redux

---
 js/actions/UserActions.js                     | 43 ++++++++-
 js/components/MoneyGoApp.js                   | 87 ++++++++-----------
 .../{NewUserForm.js => NewUserModal.js}       | 49 ++++-------
 js/constants/UserConstants.js                 |  2 +
 js/containers/NewUserModalContainer.js        | 20 +++++
 5 files changed, 117 insertions(+), 84 deletions(-)
 rename js/components/{NewUserForm.js => NewUserModal.js} (83%)
 create mode 100644 js/containers/NewUserModalContainer.js

diff --git a/js/actions/UserActions.js b/js/actions/UserActions.js
index 1efedab..33ec638 100644
--- a/js/actions/UserActions.js
+++ b/js/actions/UserActions.js
@@ -9,6 +9,20 @@ var User = models.User;
 var Session = models.Session;
 var Error = models.Error;
 
+function createUser(user) {
+	return {
+		type: UserConstants.CREATE_USER,
+		user: user
+	}
+}
+
+function userCreated(user) {
+	return {
+		type: UserConstants.USER_CREATED,
+		user: user
+	}
+}
+
 function loginUser() {
 	return {
 		type: UserConstants.LOGIN_USER
@@ -95,8 +109,34 @@ function initializeSession(dispatch, session) {
 	dispatch(SecurityActions.fetchAll());
 }
 
+function create(user) {
+	return function(dispatch) {
+		dispatch(createUser(user));
+		$.ajax({
+			type: "POST",
+			dataType: "json",
+			url: "user/",
+			data: {user: user.toJSON()},
+			success: function(data, status, jqXHR) {
+				var e = new Error();
+				e.fromJSON(data);
+				if (e.isError()) {
+					dispatch(ErrorActions.serverError(e));
+				} else {
+					var u = new User();
+					u.fromJSON(data);
+					dispatch(userCreated(u));
+				}
+			},
+			error: function(jqXHR, status, error) {
+				dispatch(ErrorActions.ajaxError(e));
+			}
+		});
+	};
+}
+
 function login(user) {
-	return function (dispatch) {
+	return function(dispatch) {
 		dispatch(loginUser());
 
 		$.ajax({
@@ -200,6 +240,7 @@ function update(user) {
 }
 
 module.exports = {
+	create: create,
 	fetch: fetch,
 	login: login,
 	logout: logout,
diff --git a/js/components/MoneyGoApp.js b/js/components/MoneyGoApp.js
index 98d27de..dd72da8 100644
--- a/js/components/MoneyGoApp.js
+++ b/js/components/MoneyGoApp.js
@@ -7,7 +7,7 @@ var Tab = ReactBootstrap.Tab;
 var Modal = ReactBootstrap.Modal;
 
 var TopBarContainer = require('../containers/TopBarContainer');
-var NewUserForm = require('./NewUserForm');
+var NewUserModalContainer = require('../containers/NewUserModalContainer');
 var AccountSettingsModalContainer = require('../containers/AccountSettingsModalContainer');
 var AccountsTabContainer = require('../containers/AccountsTabContainer');
 var SecuritiesTabContainer = require('../containers/SecuritiesTabContainer');
@@ -16,75 +16,56 @@ module.exports = React.createClass({
 	displayName: "MoneyGoApp",
 	getInitialState: function() {
 		return {
-			hash: "home",
+			showNewUserModal: false,
 			showAccountSettingsModal: false
 		};
 	},
 	componentDidMount: function() {
 		this.props.tryResumingSession();
-		this.handleHashChange();
-		if ("onhashchange" in window) {
-			window.onhashchange = this.handleHashChange;
-		}
-	},
-	handleHashChange: function() {
-		var hash = location.hash.replace(/^#/, '');
-		if (hash.length == 0)
-			hash = "home";
-		if (hash != this.state.hash)
-			this.setHash(hash);
-	},
-	setHash: function(hash) {
-		location.hash = hash;
-		if (this.state.hash != hash)
-		this.setState({hash: hash});
 	},
 	handleAccountSettings: function() {
 		this.setState({showAccountSettingsModal: true});
 	},
 	handleSettingsSubmitted: function(user) {
-		this.setState({
-			showAccountSettingsModal: false
-		});
+		this.setState({showAccountSettingsModal: false});
 	},
 	handleSettingsCanceled: function() {
 		this.setState({showAccountSettingsModal: false});
 	},
 	handleCreateNewUser: function() {
-		this.setHash("new_user");
+		this.setState({showNewUserModal: true});
 	},
-	handleGoHome: function() {
-		this.setHash("home");
+	handleNewUserCreated: function() {
+		this.setState({showNewUserModal: false});
+	},
+	handleNewUserCanceled: function() {
+		this.setState({showNewUserModal: false});
 	},
 	render: function() {
 		var mainContent;
-		if (this.state.hash == "new_user") {
-			mainContent = <NewUserForm onNewUser={this.handleGoHome} onCancel={this.handleGoHome}/>
-		} else {
-			if (this.props.user.isUser())
-				mainContent = (
-					<Tabs defaultActiveKey={1} id='mainNavigationTabs'>
-						<Tab title="Accounts" eventKey={1} >
-						<AccountsTabContainer
-							className="fullheight" />
-						</Tab>
-						<Tab title="Securities" eventKey={2} >
-						<SecuritiesTabContainer
-							className="fullheight" />
-						</Tab>
-						<Tab title="Scheduled Transactions" eventKey={3} >Scheduled transactions go here...</Tab>
-						<Tab title="Budgets" eventKey={4} >Budgets go here...</Tab>
-						<Tab title="Reports" eventKey={5} >Reports go here...</Tab>
-					</Tabs>);
-			else
-				mainContent = (
-					<Jumbotron>
-						<center>
-							<h1>Money<i>Go</i></h1>
-							<p><i>Go</i> manage your money.</p>
-						</center>
-					</Jumbotron>);
-		}
+		if (this.props.user.isUser())
+			mainContent = (
+				<Tabs defaultActiveKey={1} id='mainNavigationTabs'>
+					<Tab title="Accounts" eventKey={1} >
+					<AccountsTabContainer
+						className="fullheight" />
+					</Tab>
+					<Tab title="Securities" eventKey={2} >
+					<SecuritiesTabContainer
+						className="fullheight" />
+					</Tab>
+					<Tab title="Scheduled Transactions" eventKey={3} >Scheduled transactions go here...</Tab>
+					<Tab title="Budgets" eventKey={4} >Budgets go here...</Tab>
+					<Tab title="Reports" eventKey={5} >Reports go here...</Tab>
+				</Tabs>);
+		else
+			mainContent = (
+				<Jumbotron>
+					<center>
+						<h1>Money<i>Go</i></h1>
+						<p><i>Go</i> manage your money.</p>
+					</center>
+				</Jumbotron>);
 
 		return (
 			<div className="fullheight ui">
@@ -92,6 +73,10 @@ module.exports = React.createClass({
 					onCreateNewUser={this.handleCreateNewUser}
 					onAccountSettings={this.handleAccountSettings} />
 				{mainContent}
+				<NewUserModalContainer
+					show={this.state.showNewUserModal}
+					onSubmit={this.handleNewUserCreated}
+					onCancel={this.handleNewUserCanceled}/>
 				<AccountSettingsModalContainer
 					show={this.state.showAccountSettingsModal}
 					onSubmit={this.handleSettingsSubmitted}
diff --git a/js/components/NewUserForm.js b/js/components/NewUserModal.js
similarity index 83%
rename from js/components/NewUserForm.js
rename to js/components/NewUserModal.js
index 9a0145c..75a1f39 100644
--- a/js/components/NewUserForm.js
+++ b/js/components/NewUserModal.js
@@ -2,7 +2,7 @@ var React = require('react');
 var ReactDOM = require('react-dom');
 
 var ReactBootstrap = require('react-bootstrap');
-var Panel = ReactBootstrap.Panel;
+var Modal = ReactBootstrap.Modal;
 var Form = ReactBootstrap.Form;
 var FormGroup = ReactBootstrap.FormGroup;
 var FormControl = ReactBootstrap.FormControl;
@@ -16,6 +16,7 @@ var User = models.User;
 var Error = models.Error;
 
 module.exports = React.createClass({
+	displayName: "NewUserModal",
 	getInitialState: function() {
 		return {error: "",
 			name: "",
@@ -73,35 +74,17 @@ module.exports = React.createClass({
 			return;
 		}
 
-		this.handleCreateNewUser(u);
-	},
-	handleCreateNewUser: function(user) {
-		$.ajax({
-			type: "POST",
-			dataType: "json",
-			url: "user/",
-			data: {user: user.toJSON()},
-			success: function(data, status, jqXHR) {
-				var e = new Error();
-				e.fromJSON(data);
-				if (e.isError()) {
-					this.setState({error: e});
-				} else {
-					this.props.onNewUser();
-				}
-			}.bind(this),
-			error: function(jqXHR, status, error) {
-				var e = new Error();
-				e.ErrorId = 5;
-				e.ErrorString = "Request Failed: " + status + error;
-				this.setState({error: e});
-			}.bind(this),
-		});
+		this.props.createNewUser(u);
+		if (this.props.onSubmit != null)
+			this.props.onSubmit(u);
 	},
 	render: function() {
-		var title = <h3>Create New User</h3>;
 		return (
-			<Panel header={title} bsStyle="info">
+			<Modal show={this.props.show} onHide={this.handleCancel} bsSize="large">
+				<Modal.Header closeButton>
+					<Modal.Title>Create New user</Modal.Title>
+				</Modal.Header>
+				<Modal.Body>
 				<span color="red">{this.state.error}</span>
 				<Form horizontal onSubmit={this.handleSubmit}>
 					<FormGroup>
@@ -151,15 +134,17 @@ module.exports = React.createClass({
 						<FormControl.Feedback/>
 						</Col>
 					</FormGroup>
-
-					<ButtonGroup className="pull-right">
+				</Form>
+				</Modal.Body>
+				<Modal.Footer>
+					<ButtonGroup>
 						<Button onClick={this.handleCancel}
 								bsStyle="warning">Cancel</Button>
-						<Button type="submit"
+						<Button onClick={this.handleSubmit}
 								bsStyle="success">Create New User</Button>
 					</ButtonGroup>
-				</Form>
-			</Panel>
+				</Modal.Footer>
+			</Modal>
 		);
 	}
 });
diff --git a/js/constants/UserConstants.js b/js/constants/UserConstants.js
index f090be4..c88216e 100644
--- a/js/constants/UserConstants.js
+++ b/js/constants/UserConstants.js
@@ -1,6 +1,8 @@
 var keyMirror = require('keymirror');
 
 module.exports = keyMirror({
+	CREATE_USER: null,
+	USER_CREATED: null,
 	LOGIN_USER: null,
 	USER_LOGGEDIN: null,
 	LOGOUT_USER: null,
diff --git a/js/containers/NewUserModalContainer.js b/js/containers/NewUserModalContainer.js
new file mode 100644
index 0000000..4b7f8d9
--- /dev/null
+++ b/js/containers/NewUserModalContainer.js
@@ -0,0 +1,20 @@
+var connect = require('react-redux').connect;
+
+var UserActions = require('../actions/UserActions');
+
+var NewUserModal = require('../components/NewUserModal');
+
+function mapStateToProps(state) {
+	return {}
+}
+
+function mapDispatchToProps(dispatch) {
+	return {
+		createNewUser: function(user) {dispatch(UserActions.create(user))}
+	}
+}
+
+module.exports = connect(
+	mapStateToProps,
+	mapDispatchToProps
+)(NewUserModal)