aclindsa/moneygo
1
0
Fork 0
mirror of https://github.com/aclindsa/moneygo.git synced 2025-11-04 02:23:26 -05:00
Code Issues Releases Wiki Activity

Get all current tests to pass with MySQL

Browse Source 
This is done by requiring 'parseTime=true' in the MySQL DSN's (required
by github.com/go-sql-driver/mysql when Scan()ing to time.Time's), and
not forcing update counts to match if rows were updated to what they
already were.
This commit is contained in:
Aaron Lindsay
2017-10-24 20:57:55 -04:00
parent a1d294c309
commit 3869f3a3b2
5 changed files with 20 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
internal/handlers/common_test.go
View File

@@ -182,7 +182,8 @@ func RunTests(m *testing.M) int {
defer os.RemoveAll(tmpdir)
dbpath := path.Join(tmpdir, "moneygo.sqlite")
database, err := sql.Open("sqlite3", "file:"+dbpath+"?cache=shared&mode=rwc")
dsn := db.GetDSN(config.SQLite, "file:"+dbpath+"?cache=shared&mode=rwc")
database, err := sql.Open("sqlite3", dsn)
if err != nil {
log.Fatal(err)
}

8
internal/handlers/transactions.go
View File

@@ -316,8 +316,8 @@ func UpdateTransaction(tx *Tx, t *Transaction, user *User) error {
if err != nil {
return err
}
if count != 1 {
return errors.New("Updated more than one transaction split")
if count > 1 {
return fmt.Errorf("Updated %d transaction splits while attempting to update only 1", count)
}
delete(s_map, t.Splits[i].SplitId)
} else {
@@ -360,8 +360,8 @@ func UpdateTransaction(tx *Tx, t *Transaction, user *User) error {
if err != nil {
return err
}
if count != 1 {
return errors.New("Updated more than one transaction")
if count > 1 {
return fmt.Errorf("Updated %d transactions (expected 1)", count)
}
return nil