aclindsa/moneygo
1
0
Fork 0
mirror of https://github.com/aclindsa/moneygo.git synced 2025-11-03 18:13:27 -05:00
Code Issues Releases Wiki Activity

Stop creating lists in containers

Browse Source 
Create them only when needed in reducers instead
This commit is contained in:
Aaron Lindsay
2017-06-21 21:27:05 -04:00
parent cd9ad1d4d7
commit 25b04a4f0f
5 changed files with 57 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
js/containers/AccountsTabContainer.js
View File

@@ -8,16 +8,11 @@ var ImportActions = require('../actions/ImportActions');
var AccountsTab = require('../components/AccountsTab');
function mapStateToProps(state) {
var security_list = [];
for (var securityId in state.securities) {
if (state.securities.hasOwnProperty(securityId))
security_list.push(state.securities[securityId]);
}
return {
accounts: state.accounts.map,
accountChildren: state.accounts.children,
securities: state.securities,
security_list: security_list,
securities: state.securities.map,
security_list: state.securities.list,
selectedAccount: state.selectedAccount,
transactions: state.transactions,
transactionPage: state.transactionPage,

8
js/containers/ReportsTabContainer.js
View File

@@ -4,14 +4,8 @@ var ReportActions = require('../actions/ReportActions');
var ReportsTab = require('../components/ReportsTab');
function mapStateToProps(state) {
var report_list = [];
for (var reportId in state.reports.map) {
if (state.reports.map.hasOwnProperty(reportId))
report_list.push(state.reports.map[reportId]);
}
return {
reports: state.reports,
report_list: report_list
reports: state.reports
}
}

9
js/containers/SecuritiesTabContainer.js
View File

@@ -11,14 +11,9 @@ function mapStateToProps(state) {
&& state.accounts.map[accountId].SecurityId == state.selectedSecurity)
selectedSecurityAccounts.push(state.accounts.map[accountId]);
}
var security_list = [];
for (var securityId in state.securities) {
if (state.securities.hasOwnProperty(securityId))
security_list.push(state.securities[securityId]);
}
return {
securities: state.securities,
security_list: security_list,
securities: state.securities.map,
security_list: state.securities.list,
selectedSecurityAccounts: selectedSecurityAccounts,
selectedSecurity: state.selectedSecurity,
securityTemplates: state.securityTemplates